viirya commented on a change in pull request #35850:
URL: https://github.com/apache/spark/pull/35850#discussion_r827488245
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasingSuite.scala
##########
@@ -812,6 +812,18 @@ class NestedColumnAliasingSuite extends SchemaPruningTest {
val expected3 =
contact.select($"name").rebalance($"name").select($"name.first").analyze
comparePlans(optimized3, expected3)
}
+
+ test("GeneratorNestedColumnAliasing does not pushdown for non-Explode") {
Review comment:
Can you add JIRA ticket as prefix? E.g. `SPARK-38529:
GeneratorNestedColumnAliasing does not pushdown for non-Explode`
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasingSuite.scala
##########
@@ -292,7 +292,7 @@ class NestedColumnAliasingSuite extends SchemaPruningTest {
comparePlans(optimized, expected)
}
- test("Nested field pruning for Project and Generate") {
+ test("Nested field pruning for Project and Explode") {
Review comment:
This is unnecessary change. Can you revert it back?
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
##########
@@ -447,9 +478,6 @@ object GeneratorNestedColumnAliasing {
*/
def canPruneGenerator(g: Generator): Boolean = g match {
case _: Explode => true
- case _: Stack => true
- case _: PosExplode => true
Review comment:
Do we need to remove `PosExplode`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
