LuciferYang commented on pull request #35847: URL: https://github.com/apache/spark/pull/35847#issuecomment-1068677144
> Trying to understand why we are making this change - what is the reason to go from `SocketChannel` to `Channel` ? Netty does not only support `SocketChannel`, for example, `LocalChannel` is not this inheritance level, and there may be more in the future. Although Spark only supports `NIO` and `EPOLL` `IOMode` now, there may be more in the future and they are not all derived from `SocketChannel`. The change of current pr does not affect the existing behavior and provides more possibilities for expansion. However, this change is not important at present. We can wait until it is really necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
