cloud-fan commented on a change in pull request #35863:
URL: https://github.com/apache/spark/pull/35863#discussion_r827658827
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
##########
@@ -825,7 +825,7 @@ case class NTile(buckets: Expression) extends RowNumberLike
with SizeBasedWindow
zero,
zero,
zero,
- (n.cast(DecimalType.IntDecimal) /
buckets.cast(DecimalType.IntDecimal)).cast(IntegerType),
+ (n div buckets).cast(IntegerType),
Review comment:
yea, it's a new fix to replace
https://github.com/apache/spark/commit/ec8a1a8e8869b000a8001126ca013b753acddf6a
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
##########
@@ -825,7 +825,7 @@ case class NTile(buckets: Expression) extends RowNumberLike
with SizeBasedWindow
zero,
zero,
zero,
- (n.cast(DecimalType.IntDecimal) /
buckets.cast(DecimalType.IntDecimal)).cast(IntegerType),
+ (n div buckets).cast(IntegerType),
Review comment:
yea, it's a better fix to replace
https://github.com/apache/spark/commit/ec8a1a8e8869b000a8001126ca013b753acddf6a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
