somani commented on a change in pull request #35789:
URL: https://github.com/apache/spark/pull/35789#discussion_r828021703
##########
File path:
common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilter.java
##########
@@ -163,6 +163,13 @@ int getVersionNumber() {
*/
public abstract void writeTo(OutputStream out) throws IOException;
+ /**
+ * @return the number of set bits in this {@link BloomFilter}.
+ */
+ public long cardinality() {
+ throw new UnsupportedOperationException("Not implemented");
Review comment:
Turns out BloomFilter is public, and removing this caused backward
compatibility tests to fail.
```
[error] spark-sketch: Failed binary compatibility check against
org.apache.spark:spark-sketch_2.12:3.2.0! Found 1 potential problems (filtered
1)
[error] * abstract method cardinality()Long in class
org.apache.spark.util.sketch.BloomFilter is present only in current version
[error] filter with:
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.util.sketch.BloomFilter.cardinality")
```
So added this back again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
