cloud-fan commented on a change in pull request #35710:
URL: https://github.com/apache/spark/pull/35710#discussion_r828070294
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala
##########
@@ -169,7 +169,7 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession
with ExplainSuiteHel
}
private def checkPushedLimit(df: DataFrame, limit: Option[Int] = None,
- sortValues: Seq[SortValue] = Nil): Unit = {
+ sortValues: Seq[SortValue] = Nil, sortRemoved: Boolean = false): Unit = {
Review comment:
I think the default value of `sortRemoved` should be true. It's more
interesting to see which tests can't remove the sort while top N is pushed down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
