tgravescs commented on a change in pull request #35085:
URL: https://github.com/apache/spark/pull/35085#discussion_r828063986
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -659,6 +659,14 @@ package object config {
.booleanConf
.createWithDefault(false)
+ private[spark] val SHUFFLE_SERVICE_REMOVE_SHUFFLE_ENABLED =
+ ConfigBuilder("spark.shuffle.service.removeShuffle")
+ .doc("Whether to use the ExternalShuffleService for deleting shuffle
blocks for " +
+ "deallocated executors.")
Review comment:
comment on permissions change.
this description is really unclear to me, and actually so is the title on
this. I think we need to reword and be specific here. I assume shuffle blocks
aren't removed when executor just deallocated, otherwise things would break
very quickly. They are only removed when the RDD isn't referenced anymore and
context cleaner cleans them up, correct?
This also needs to go into the configuration.md so it shows up in the docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
