Github user mridulm commented on a diff in the pull request:

    https://github.com/apache/spark/pull/731#discussion_r12511553
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala 
---
    @@ -532,6 +516,99 @@ private[spark] class Master(
         }
       }
     
    +  private def startMultiExecutorsPerWorker() {
    +    // allow user to run multiple executors in the same worker
    +    // (within the same worker JVM process)
    +    if (spreadOutApps) {
    +      for (app <- waitingApps if app.coresLeft > 0) {
    +        val memoryPerExecutor = app.desc.memoryPerExecutor
    +        var usableWorkers = workers.toArray.filter(_.state == 
WorkerState.ALIVE).
    +          filter(worker => worker.coresFree > 0 && worker.memoryFree >= 
memoryPerExecutor).
    +          sortBy(_.memoryFree / memoryPerExecutor).reverse
    +        val maxCoreNumPerExecutor = app.desc.maxCorePerExecutor.get
    +        // get the maximum total number of executors we can assign
    +        var maxLeftExecutorsToAssign = usableWorkers.map(_.memoryFree / 
memoryPerExecutor).sum
    +        var maxCoresLeft = maxLeftExecutorsToAssign * maxCoreNumPerExecutor
    +        val numUsable = usableWorkers.length
    +        // Number of cores of each executor assigned to each worker
    +        val assigned = Array.fill[ListBuffer[Int]](numUsable)(new 
ListBuffer[Int])
    +        val assignedSum = Array.fill[Int](numUsable)(0)
    +        var pos = 0
    +        val noEnoughMemoryWorkers = new HashSet[Int]
    +        while (maxLeftExecutorsToAssign > 0 && noEnoughMemoryWorkers.size 
< numUsable) {
    +          if (usableWorkers(pos).coresFree - assignedSum(pos) >= 0) {
    --- End diff --
    
    > 0 ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to