srielau commented on a change in pull request #35352:
URL: https://github.com/apache/spark/pull/35352#discussion_r828167144
##########
File path:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
##########
@@ -999,13 +1000,22 @@ public static UTF8String concatWs(UTF8String separator,
UTF8String... inputs) {
}
public UTF8String[] split(UTF8String pattern, int limit) {
+ return split(pattern, limit, false);
+ }
+
+ public UTF8String[] split(UTF8String pattern, int limit, boolean ifQuote) {
Review comment:
Let's go back to first principles: Why are we adding split_part? Who is
expected to use it?
Is the need organic, because users want a faster way to write something they
can already do?
Or is the need to fill a functional gap and there are expectations of a
different behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
