peter-toth edited a comment on pull request #32298: URL: https://github.com/apache/spark/pull/32298#issuecomment-1070887317
@tgravescs, thanks for your feedback and interest in in this PR. I reran the tests, they seem to be fine now. This change adds basic subquery merging logic and affects only `q9` from TPCDS, but it brings considerable performance improvement to it. The change has been ready for review for a while, but haven't got much attention. Your and others review would be much appreciated. I also have some follow-up PRs/plans: - to add more advanced logic to support merging aggregate subqueries with different `Filter` nodes - support DSv2 - try merging correlated subqueries but this PR is complex enough so I would add these in subsequent PRs only. We can target 3.3, but AFAIK the branch has been cut so probably we need some kind of approval on the dev list? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
