weixiuli commented on a change in pull request #35884:
URL: https://github.com/apache/spark/pull/35884#discussion_r829995164



##########
File path: 
sql/core/src/main/scala/org/apache/spark/status/api/v1/sql/SqlResource.scala
##########
@@ -94,7 +95,15 @@ private[v1] class SqlResource extends BaseAppResource {
 
     val duration = exec.completionTime.getOrElse(new Date()).getTime - 
exec.submissionTime
     val planDetails = if (planDescription) exec.physicalPlanDescription else ""
-    val nodes = if (details) printableMetrics(graph.allNodes, 
exec.metricValues) else Seq.empty

Review comment:
       Maybe we can make a small change,like:
   
   ``` val nodes = if (details) printableMetrics(graph.allNodes,  
Option(exec.metricValues).getOrElse(new HashMap[Long, String])) else 
Seq.empty```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to