dongjoon-hyun commented on a change in pull request #35830:
URL: https://github.com/apache/spark/pull/35830#discussion_r830399228
##########
File path:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/TestConstants.scala
##########
@@ -34,4 +34,6 @@ object TestConstants {
val CONFIG_KEY_IMAGE_TAG_FILE = "spark.kubernetes.test.imageTagFile"
val CONFIG_KEY_IMAGE_REPO = "spark.kubernetes.test.imageRepo"
val CONFIG_KEY_UNPACK_DIR = "spark.kubernetes.test.unpackSparkDir"
+ val CONFIG_DRIVER_REQUEST_CPU = "spark.kubernetes.test.driver.cpu"
Review comment:
We don't want to introduce a namespace with a single child. `driver`
doesn't have any other child.
##########
File path:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/TestConstants.scala
##########
@@ -34,4 +34,6 @@ object TestConstants {
val CONFIG_KEY_IMAGE_TAG_FILE = "spark.kubernetes.test.imageTagFile"
val CONFIG_KEY_IMAGE_REPO = "spark.kubernetes.test.imageRepo"
val CONFIG_KEY_UNPACK_DIR = "spark.kubernetes.test.unpackSparkDir"
+ val CONFIG_DRIVER_REQUEST_CPU = "spark.kubernetes.test.driver.cpu"
+ val CONFIG_EXECUTOR_REQUEST_CPU = "spark.kubernetes.test.executor.cpu"
Review comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
