HeartSaVioR commented on a change in pull request #35872:
URL: https://github.com/apache/spark/pull/35872#discussion_r830809125
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/ReportSinkMetricsSuite.scala
##########
@@ -94,11 +99,10 @@ class ReportSinkMetricsSuite extends StreamTest {
TestSinkTable
}
- def createRelation(
- sqlContext: SQLContext,
- mode: SaveMode,
- parameters: Map[String, String],
- data: DataFrame): BaseRelation = {
+ def createRelation(sqlContext: SQLContext,
Review comment:
probably the last nit: the indentation rule Spark uses is quite
different with others, hence you'd like to refer to the Scala style guide.
https://github.com/databricks/scala-style-guide
https://github.com/databricks/scala-style-guide#spacing-and-indentation
> For method declarations, use 4 space indentation for their parameters and
put each in each line when the parameters don't fit in two lines. Return types
can be either on the same line as the last parameter, or start a new line with
2 space indent.
Below is the correct indentation for this case.
```
def createRelation(
sqlContext: SQLContext,
mode: SaveMode,
parameters: Map[String, String],
data: DataFrame): BaseRelation = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
