Yikun commented on a change in pull request #35782:
URL: https://github.com/apache/spark/pull/35782#discussion_r830896890
##########
File path: python/pyspark/pandas/series.py
##########
@@ -1603,6 +1603,83 @@ def to_list(self) -> List:
tolist = to_list
+ def duplicated(self, keep: str = "first") -> "Series":
Review comment:
```suggestion
def duplicated(self, keep: Union[bool, str] = "first") -> "Series":
```
Looks like `keep` can be str or bool, I also submit a fix on other wrong
hint https://github.com/apache/spark/pull/35920
##########
File path: python/pyspark/pandas/series.py
##########
@@ -1603,6 +1603,83 @@ def to_list(self) -> List:
tolist = to_list
+ def duplicated(self, keep: str = "first") -> "Series":
Review comment:
```suggestion
def duplicated(self, keep: Union[bool, str] = "first") -> "Series":
```
Looks like `keep` can be str or bool, I also submit a fix on other wrong
hints https://github.com/apache/spark/pull/35920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
