cloud-fan commented on a change in pull request #35921:
URL: https://github.com/apache/spark/pull/35921#discussion_r831691249
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala
##########
@@ -185,17 +185,28 @@ class JDBCV2Suite extends QueryTest with
SharedSparkSession with ExplainSuiteHel
}
}
+ private def checkPushedInfo(df: DataFrame, expectedPlanFragment: String):
Unit = {
+ df.queryExecution.optimizedPlan.collect {
+ case _: DataSourceV2ScanRelation =>
+ checkKeywordsExistsInExplain(df, expectedPlanFragment)
+ }
+ }
+
test("simple scan with top N") {
val df1 = spark.read
.table("h2.test.employee")
.sort("salary")
.limit(1)
checkPushedLimit(df1, Some(1), createSortValues())
Review comment:
Seems we don't need these methods anymore? `checkPushedInfo` can cover
all of them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
