LuciferYang opened a new pull request #35953:
URL: https://github.com/apache/spark/pull/35953


   ### What changes were proposed in this pull request?
   `Test that might_contain errors out non-constant Bloom filter` in 
`BloomFilterAggregateQuerySuite ` failed in ansi mode due to `Numeric <=> 
Binary` is [not allowed in ansi 
mode](https://github.com/apache/spark/pull/30260),  so the content of  
`exception.getMessage` is different from that of non-ans mode.
   
   This pr change the case to ensure that the error messages of `ansi` mode and 
`non-ansi` are consistent.
   
   
   ### Why are the changes needed?
   Bug fix.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   
   - Pass GA
   - Local Test
   
   **Before**
   
   ```
   export SPARK_ANSI_SQL_MODE=false
   mvn clean test -pl sql/core -am -Dtest=none 
-DwildcardSuites=org.apache.spark.sql.BloomFilterAggregateQuerySuite
   ```
   
   ```
   Run completed in 23 seconds, 537 milliseconds.
   Total number of tests run: 8
   Suites: completed 2, aborted 0
   Tests: succeeded 8, failed 0, canceled 0, ignored 0, pending 0
   All tests passed.
   ```
   
   ```
   export SPARK_ANSI_SQL_MODE=true
   mvn clean test -pl sql/core -am -Dtest=none 
-DwildcardSuites=org.apache.spark.sql.BloomFilterAggregateQuerySuite
   ```
   
   ```
   - Test that might_contain errors out non-constant Bloom filter *** FAILED ***
     "cannot resolve 'CAST(t.a AS BINARY)' due to data type mismatch: 
      cannot cast bigint to binary with ANSI mode on.
      If you have to cast bigint to binary, you can set spark.sql.ansi.enabled 
as false.
     ; line 2 pos 21;
     'Project [unresolvedalias('might_contain(cast(a#2424L as binary), cast(5 
as bigint)), None)]
     +- SubqueryAlias t
        +- LocalRelation [a#2424L]
     " did not contain "The Bloom filter binary input to might_contain should 
be either a constant value or a scalar subquery expression" 
(BloomFilterAggregateQuerySuite.scala:171)
   ```
   
   
   
   **After**
   ```
   export SPARK_ANSI_SQL_MODE=false
   mvn clean test -pl sql/core -am -Dtest=none 
-DwildcardSuites=org.apache.spark.sql.BloomFilterAggregateQuerySuite
   ```
   
   ```
   Run completed in 26 seconds, 544 milliseconds.
   Total number of tests run: 8
   Suites: completed 2, aborted 0
   Tests: succeeded 8, failed 0, canceled 0, ignored 0, pending 0
   All tests passed.
   
   ```
   
   ```
   export SPARK_ANSI_SQL_MODE=true
   mvn clean test -pl sql/core -am -Dtest=none 
-DwildcardSuites=org.apache.spark.sql.BloomFilterAggregateQuerySuite
   ```
   
   ```
   Run completed in 25 seconds, 289 milliseconds.
   Total number of tests run: 8
   Suites: completed 2, aborted 0
   Tests: succeeded 8, failed 0, canceled 0, ignored 0, pending 0
   All tests passed.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to