viirya commented on a change in pull request #35680:
URL: https://github.com/apache/spark/pull/35680#discussion_r833828126
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -4061,10 +4061,30 @@ object SessionWindowing extends Rule[LogicalPlan] {
case s: SessionWindow => sessionAttr
}
+ def isGapInvalid(child: Expression): Boolean = {
+ val calendarInterval = IntervalUtils
+ .safeStringToInterval(UTF8String.fromString(child.toString))
+ calendarInterval == null ||
+ calendarInterval.months + calendarInterval.days +
calendarInterval.microseconds <= 0
+ }
+
+ val filterTimeSize = gapDuration match {
+ case gapDuration if
gapDuration.find(_.isInstanceOf[ScalaUDF]).nonEmpty => true
+ case _ => gapDuration.child.children match {
+ case children if children.size > 0 =>
+ children.filter(_.dataType !=
BooleanType).exists(isGapInvalid(_))
+ case _ => isGapInvalid(gapDuration.child)
+ }
Review comment:
Seems we only need to check if the (casted) gap duration expression is
foldable. If so, just evaluating it to get Calendar Interval value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
