nyingping commented on a change in pull request #35680:
URL: https://github.com/apache/spark/pull/35680#discussion_r833908883
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -4061,10 +4061,30 @@ object SessionWindowing extends Rule[LogicalPlan] {
case s: SessionWindow => sessionAttr
}
+ def isGapInvalid(child: Expression): Boolean = {
+ val calendarInterval = IntervalUtils
+ .safeStringToInterval(UTF8String.fromString(child.toString))
Review comment:
@viirya
Thanks for reivew!
So far, I have judged two cases: static gap and `case when` expression. The
case when expression filters the `BooleanType`. I'm not sure if there's
anything missing.
Yes, I agree with your second point. I'm also trying to find a better way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
