tgravescs commented on a change in pull request #35085:
URL: https://github.com/apache/spark/pull/35085#discussion_r834436231
##########
File path: core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala
##########
@@ -78,8 +78,12 @@ private[spark] class DiskBlockManager(
private val shutdownHook = addShutdownHook()
- private val shuffleServiceRemoveShuffleEnabled =
conf.get(config.SHUFFLE_SERVICE_ENABLED) &&
- conf.get(config.SHUFFLE_SERVICE_REMOVE_SHUFFLE_ENABLED)
+ // If either of these features are enabled, we must change permissions on
block manager
+ // directories and files to accomodate the shuffle service deleting files in
a secure environment
Review comment:
nit - only other thing here might be nice to say in secure environment
parent directory is assumed to be restrictive to prevent unauthorized users for
accessing or modifying.
##########
File path: core/src/main/scala/org/apache/spark/storage/DiskStore.scala
##########
@@ -71,6 +74,13 @@ private[spark] class DiskStore(
logDebug(s"Attempting to put block $blockId")
val startTimeNs = System.nanoTime()
val file = diskManager.getFile(blockId)
+
+ // SPARK-37618: If fetching cached RDDs from the shuffle service is
enabled, we must
+ // make the file world readable, as it will not be owned by the gropu
running the shuffle
Review comment:
nit group misspelled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
