peter-toth commented on a change in pull request #32298:
URL: https://github.com/apache/spark/pull/32298#discussion_r834760728
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala
##########
@@ -253,20 +253,14 @@ class InjectRuntimeFilterSuite extends QueryTest with
SQLTestUtils with SharedSp
}
def getNumBloomFilters(plan: LogicalPlan): Integer = {
- val numBloomFilterAggs = plan.collect {
- case Filter(condition, _) => condition.collect {
- case subquery: org.apache.spark.sql.catalyst.expressions.ScalarSubquery
- => subquery.plan.collect {
- case Aggregate(_, aggregateExpressions, _) =>
- aggregateExpressions.map {
- case Alias(AggregateExpression(bfAgg : BloomFilterAggregate, _,
_, _, _),
- _) =>
- assert(bfAgg.estimatedNumItemsExpression.isInstanceOf[Literal])
- assert(bfAgg.numBitsExpression.isInstanceOf[Literal])
- 1
- }.sum
+ val numBloomFilterAggs = plan.collectWithSubqueries {
Review comment:
Ditto. Let me know it this check is too loose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
