itholic commented on a change in pull request #35888:
URL: https://github.com/apache/spark/pull/35888#discussion_r836909563
##########
File path: python/pyspark/pandas/frame.py
##########
@@ -10066,7 +10071,7 @@ def unstack(self) -> DataFrameOrSeries:
)
# TODO: axis, skipna, and many arguments should be implemented.
Review comment:
Now we're only missing `level` and `**kwargs`.
Can we fix this to `# TODO: axis, skipna, level and **kwargs should be
implemented.` while we're here ??
##########
File path: python/pyspark/pandas/frame.py
##########
@@ -10081,6 +10086,10 @@ def all(self, axis: Axis = 0) -> "Series":
* 0 / 'index' : reduce the index, return a Series whose index is
the
original column labels.
+ bool_only : bool, default None
+ Include only boolean columns. If None, will attempt to use
everything,
+ then use only boolean data.
Review comment:
Don't we need `Not implemented for Series.` ??
Seems like it's mentioned in pandas documents as below:
<img width="641" alt="Screen Shot 2022-03-29 at 7 42 37 AM"
src="https://user-images.githubusercontent.com/44108233/160498960-000043f6-5ecd-4652-a143-6b541a5fd331.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/44108233/160498960-000043f6-5ecd-4652-a143-6b541a5fd331.png"](https://user-images.githubusercontent.com/44108233/160498960-000043f6-5ecd-4652-a143-6b541a5fd331.png"){kind=link}