[GitHub] [spark] HyukjinKwon commented on a change in pull request #35973: [SPARK-38657][UI][SQL] Rename 'SQL' to 'SQL / DataFrame' in SQL UI page

Mon, 28 Mar 2022 20:16:37 -0700 


HyukjinKwon commented on a change in pull request #35973:
URL: https://github.com/apache/spark/pull/35973#discussion_r837017796



##########
File path: core/src/main/resources/org/apache/spark/ui/static/webui.css
##########
@@ -88,12 +88,14 @@ a:not([href]):hover {
   height: 50px;
   padding: 10px 15px 10px;
   line-height: 2;
+  white-space: nowrap;
 }
 
 .navbar .navbar-nav .nav-item.active .nav-link {
   background-color: #e5e5e5;
   box-shadow: inset 0 3px 8px rgba(0, 0, 0, 0.125);
   color: #555555;
+  white-space: nowrap;

Review comment:
       I piggyback one CSS change. Because `SQL / DataFrame` contains 
whitespace, we should make sure this line is separated (or wrapped) to the next 
line.
   
   Before:
   
   <img width="717" alt="Screen Shot 2022-03-29 at 12 16 03 PM" 
src="https://user-images.githubusercontent.com/6477701/160526045-7cffbb9f-37c4-4555-a9a0-447b9d538485.png";>
   
   After:
   
   <img width="723" alt="Screen Shot 2022-03-29 at 12 16 06 PM" 
src="https://user-images.githubusercontent.com/6477701/160526054-f8657091-f30a-40a9-9232-08a3d69f6334.png";>
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to