beliefer commented on a change in pull request #36003:
URL: https://github.com/apache/spark/pull/36003#discussion_r838270450
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -226,9 +226,10 @@ trait CheckAnalysis extends PredicateHelper with
LookupCatalog {
// Only allow window functions with an aggregate expression or an
offset window
// function or a Pandas window UDF.
w.windowFunction match {
- case AggregateExpression(_: PercentileCont, _, _, _, _)
- if w.windowSpec.orderSpec.nonEmpty ||
w.windowSpec.frameSpecification !=
- SpecifiedWindowFrame(RowFrame, UnboundedPreceding,
UnboundedFollowing) =>
+ case AggregateExpression(percentile: Percentile, _, _, _, _)
Review comment:
Does match Percentile looks overkill too? @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
