cloud-fan commented on a change in pull request #36012:
URL: https://github.com/apache/spark/pull/36012#discussion_r839214589



##########
File path: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SubexpressionEliminationSuite.scala
##########
@@ -419,6 +420,21 @@ class SubexpressionEliminationSuite extends SparkFunSuite 
with ExpressionEvalHel
     }
   }
 
+  test("SPARK-38333: PlanExpression expression should skip addExprTree 
function in Executor") {
+    try {
+      // support we in executor

Review comment:
       ```suggestion
         // suppose we in executor
   ```

##########
File path: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SubexpressionEliminationSuite.scala
##########
@@ -419,6 +420,21 @@ class SubexpressionEliminationSuite extends SparkFunSuite 
with ExpressionEvalHel
     }
   }
 
+  test("SPARK-38333: PlanExpression expression should skip addExprTree 
function in Executor") {
+    try {
+      // support we in executor

Review comment:
       ```suggestion
         // suppose we are in executor
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to