sunchao commented on a change in pull request #35657: URL: https://github.com/apache/spark/pull/35657#discussion_r840819827
########## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/partitioning/KeyGroupedPartitioning.java ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.read.partitioning; + +import org.apache.spark.annotation.Evolving; +import org.apache.spark.sql.connector.expressions.Expression; + +/** + * Represents a partitioning where rows are split across partitions based on the + * partition transform expressions returned by {@link KeyGroupedPartitioning#clustering}. + * <p> + * Note: Data source implementations should make sure that for a single partition, all of its + * rows must be evaluated to the same partition value after being applied by + * {@link KeyGroupedPartitioning#clustering} expressions. Different partitions can share the same + * partition value: Spark will group these into a single logical partition during planning phase. + * + * @since 3.3.0 + */ +@Evolving +public class KeyGroupedPartitioning implements Partitioning { + private final Expression[] clustering; Review comment: 👍 I think `keys` sounds better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
