dcoliversun commented on a change in pull request #36044:
URL: https://github.com/apache/spark/pull/36044#discussion_r841134142
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
##########
@@ -67,7 +67,7 @@ private[spark] class DriverCommandFeatureStep(conf:
KubernetesDriverConf)
// re-write primary resource, app jar is also added to spark.jars by
default in SparkSubmit
// no uploading takes place here
val newResName = KubernetesUtils
- .renameMainAppResource(resource = res, shouldUploadLocal = false)
+ .renameMainAppResource(res, Option(conf.sparkConf), false)
Review comment:
Thanks for your comments.
To @martin-g , I add name for boolean on
https://github.com/apache/spark/pull/36044/commits/7dd1d0517b21ab277fcd2db785b3f2ce397c03c3.
Please review~
To @dongjoon-hyun , it's not necessary to add Spark Config. My original
intention is to keep consistent with the deleted code signature. Now I choose
to delete it to reduce unnecessary misunderstandings on
https://github.com/apache/spark/pull/36044/commits/7dd1d0517b21ab277fcd2db785b3f2ce397c03c3
😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
