dongjoon-hyun commented on a change in pull request #35886:
URL: https://github.com/apache/spark/pull/35886#discussion_r841159948
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
##########
@@ -74,16 +74,8 @@ private[spark] class BasicDriverFeatureStep(conf:
KubernetesDriverConf)
private val driverMemoryWithOverheadMiB = driverMemoryMiB + memoryOverheadMiB
override def configurePod(pod: SparkPod): SparkPod = {
- val driverCustomEnvs = (Seq(
- (ENV_APPLICATION_ID, conf.appId)
- ) ++ conf.environment)
- .map { env =>
- new EnvVarBuilder()
- .withName(env._1)
- .withValue(env._2)
- .build()
- }
-
+ val driverCustomEnvs = KubernetesUtils.buildEnvVars(
+ conf.environment + (ENV_APPLICATION_ID -> conf.appId))
Review comment:
Ur, are you sure about this change? This looks inconsistent to me
because this breaks the existing behavior. Previously, `conf.environment`'s
`ENV_APPLICATION_ID` supersedes if there is a duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
