lw33 commented on pull request #35979: URL: https://github.com/apache/spark/pull/35979#issuecomment-1086831394
> Sorry guys. Supporting `illegal char` by removing `toURI` doesn't look like a safe improvement to me. > > Given the trade-off between benefit and risk, we had better recommend to avoid this kind of **illegal char** usage instead, @lw33 . Why we need `toURI` here, i see the parent class `SingleEventLogFileWriter` `logpath` is `Path.toString`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
