Kimahriman commented on code in PR #35959:
URL: https://github.com/apache/spark/pull/35959#discussion_r842436352


##########
core/src/test/scala/org/apache/spark/ExternalShuffleServiceSuite.scala:
##########
@@ -255,4 +255,22 @@ class ExternalShuffleServiceSuite extends ShuffleSuite 
with BeforeAndAfterAll wi
       }
     }
   }
+
+  test("SPARK-38640: using external shuffle service fetching disk persisted 
blocks") {
+    val confWithRddFetchEnabled = 
conf.clone.set(config.SHUFFLE_SERVICE_FETCH_RDD_ENABLED, true)

Review Comment:
   I guess if you want to make sure just having the shuffle service enabled 
doesn't affect this. I expect there's other tests testing all the default 
configs with all the caching behaviors



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to