sigmod commented on code in PR #32298:
URL: https://github.com/apache/spark/pull/32298#discussion_r844050894


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala:
##########
@@ -615,4 +603,23 @@ object QueryPlan extends PredicateHelper {
       case e: AnalysisException => append(e.toString)
     }
   }
+
+  /**
+   * Extracts expressions from an object.
+   */
+  def extractExpressions(o: Any): Seq[Expression] = {

Review Comment:
   Ack. 
   See my next comment: 
https://github.com/apache/spark/pull/32298#discussion_r843738869.  I was 
thinking that if we use explicit pattern matchings of node types, maybe we 
don't need to expose it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to