cloud-fan commented on code in PR #36069:
URL: https://github.com/apache/spark/pull/36069#discussion_r845094250
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/SourceOptions.scala:
##########
@@ -47,4 +47,6 @@ object SourceOptions {
val RESPECT_SPARK_SCHEMA = "respectSparkSchema"
val DEFAULT_RESPECT_SPARK_SCHEMA = false
Review Comment:
maybe all the `XXXOptions` should extend `SourceOptions`, so that we can put
common code here, e.g.
```
val ignoreCorruptFiles: Boolean =
parameters.get("ignoreCorruptFiles").map(_.toBoolean)
.getOrElse(SQLConf.get.ignoreCorruptFiles)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
