Yikun commented on code in PR #36112:
URL: https://github.com/apache/spark/pull/36112#discussion_r845814528
##########
python/pyspark/tests/test_util.py:
##########
@@ -73,6 +75,15 @@ def test_parsing_version_string(self):
self.assertRaises(ValueError, lambda:
VersionUtils.majorMinorVersion("abced"))
+ def test_find_spark_home(self):
+ # SPARK-38827: Test find_spark_home without `SPARK_HOME` environment
variable set.
+ origin = os.environ["SPARK_HOME"]
Review Comment:
Note: If `_find_spark_home` doesn't work for some reason, will raise in here
directly with `KeyError` to warn users about regression. I think it's reasonable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
