gengliangwang commented on code in PR #36077:
URL: https://github.com/apache/spark/pull/36077#discussion_r846209038


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -3398,6 +3399,8 @@ class Analyzer(override val catalogManager: 
CatalogManager)
       SchemaUtils.checkColumnNameDuplication(
         i.userSpecifiedCols, "in the column list", resolver)
 
+      i.setTagValue(USER_SPECIFIED_COLUMNS_RESOLVED, true)

Review Comment:
   > Note, this ResolveDefaultColumns rule currently depends on the whole 
InsertIntoStatement not being analyzed yet. So now it checks that the new 
TreeNodeTag is unset.
   
   @dtenedor Oh I didn't realize this. Let's skip setting/reading the tag to 
make it simple.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to