minyyy commented on code in PR #36121:
URL: https://github.com/apache/spark/pull/36121#discussion_r846367067
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSet.scala:
##########
@@ -74,49 +83,37 @@ class ExpressionSet protected(
protected def remove(e: Expression): Unit = {
if (e.deterministic) {
- baseSet --= baseSet.filter(_ == e.canonicalized)
- originals --= originals.filter(_.canonicalized == e.canonicalized)
+ baseSet.retain(_ != e.canonicalized)
Review Comment:
`baseSet.retain(_ != e.canonicalized)` only needs to traverse the set once,
much better than the previous implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
