huaxingao commented on code in PR #36092:
URL: https://github.com/apache/spark/pull/36092#discussion_r846583108
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/PushDownUtils.scala:
##########
@@ -116,7 +116,11 @@ object PushDownUtils extends PredicateHelper {
}
/**
- * Pushes down LIMIT to the data source Scan
+ * Pushes down LIMIT to the data source Scan.
+ *
+ * @return the tuple of Boolean. The first Boolean value represents whether
to push down, and
+ * the second Boolean value represents whether to push down
partially which means to
+ * keep the `Limit`.
Review Comment:
can we be a little more clear and say something like
`...the second Boolean value represents whether to push down partially,
which means Spark will keep the Limit and do it again.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]