LuciferYang commented on code in PR #36119:
URL: https://github.com/apache/spark/pull/36119#discussion_r846705314
##########
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala:
##########
@@ -1261,74 +1328,6 @@ class FsHistoryProviderSuite extends SparkFunSuite with
Matchers with Logging {
}
}
- test("backwards compatibility with LogInfo from Spark 2.4") {
Review Comment:
@dongjoon-hyun If we think this pr changed too much, I have another way:
1. Directly change `FsHistoryProviderSuite` into an abstract class without
moving any UTs
2. Add subclasses `LevelDBBackendFsHistoryProviderSuite` and
`RocksDBBackendFsHistoryProviderSuite` of `FsHistoryProviderSuite` to test
different DiskBackend
This way should make the changes look few, but he disadvantage is the above
6 UT will be tested repeatedly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
