gengliangwang commented on code in PR #36137:
URL: https://github.com/apache/spark/pull/36137#discussion_r846989194
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala:
##########
@@ -487,7 +488,8 @@ private[parquet] class ParquetRowConverter(
parquetType.asPrimitiveType().getPrimitiveTypeName == INT64 &&
parquetType.getLogicalTypeAnnotation.isInstanceOf[TimestampLogicalTypeAnnotation]
&&
!parquetType.getLogicalTypeAnnotation
- .asInstanceOf[TimestampLogicalTypeAnnotation].isAdjustedToUTC
+ .asInstanceOf[TimestampLogicalTypeAnnotation].isAdjustedToUTC &&
+ Utils.isTesting
Review Comment:
@cloud-fan Since we decided to release NTZ in 3.4 version, there should not
be TODO in 3.3 code base.
We can have a simple comment like
```
// SPARK-38829: Remove TimestampNTZ type support in Parquet for Spark 3.3
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
