dongjoon-hyun commented on code in PR #36138:
URL: https://github.com/apache/spark/pull/36138#discussion_r847691066
##########
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala:
##########
@@ -63,8 +64,20 @@ import org.apache.spark.util.{ResetSystemProperties,
ShutdownHookManager, Utils}
* expectations. However, in general this should be done with extreme
caution, as the metrics
* are considered part of Spark's public api.
*/
-class HistoryServerSuite extends SparkFunSuite with BeforeAndAfter with
Matchers with MockitoSugar
- with JsonTestUtils with Eventually with WebBrowser with LocalSparkContext
+
+@ExtendedLevelDBTest
+class LevelDBBackendHistoryServerSuite extends HistoryServerSuite {
+ override protected def diskBackend: History.HybridStoreDiskBackend.Value =
+ HybridStoreDiskBackend.LEVELDB
+}
+
+class RocksDBBackendHistoryServerSuite extends HistoryServerSuite {
+ override protected def diskBackend: History.HybridStoreDiskBackend.Value =
+ HybridStoreDiskBackend.ROCKSDB
+}
Review Comment:
Please move these derived classes at the end of this file. We prefer to put
`abstract class HistoryServerSuite` at the beginning because this file name is
`HistoryServerSuite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
