zero323 commented on code in PR #34293:
URL: https://github.com/apache/spark/pull/34293#discussion_r847713725
##########
python/pyspark/streaming/context.py:
##########
@@ -313,14 +338,19 @@ def binaryRecordsStream(self, directory, recordLength):
self._jssc.binaryRecordsStream(directory, recordLength), self,
NoOpSerializer()
)
- def _check_serializers(self, rdds):
+ def _check_serializers(self, rdds: List[RDD[T]]) -> None:
# make sure they have same serializer
- if len(set(rdd._jrdd_deserializer for rdd in rdds)) > 1:
+ if len(set(rdd._jrdd_deserializer for rdd in rdds)) > 1: # type:
ignore[attr-defined]
Review Comment:
This ignore won't be necessary, once it is re-synced with master.
##########
python/pyspark/streaming/context.py:
##########
@@ -313,14 +338,19 @@ def binaryRecordsStream(self, directory, recordLength):
self._jssc.binaryRecordsStream(directory, recordLength), self,
NoOpSerializer()
)
- def _check_serializers(self, rdds):
+ def _check_serializers(self, rdds: List[RDD[T]]) -> None:
# make sure they have same serializer
- if len(set(rdd._jrdd_deserializer for rdd in rdds)) > 1:
+ if len(set(rdd._jrdd_deserializer for rdd in rdds)) > 1: # type:
ignore[attr-defined]
for i in range(len(rdds)):
# reset them to sc.serializer
- rdds[i] = rdds[i]._reserialize()
+ rdds[i] = rdds[i]._reserialize() # type: ignore[attr-defined]
Review Comment:
This ignore won't be necessary, once it is re-synced with master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
