ulysses-you commented on PR #36117: URL: https://github.com/apache/spark/pull/36117#issuecomment-1096133807
@wangyum good catch, seems `EliminateDistinct` should move to the place which after `Finish Analysis` batch. Why we put `EliminateDistinct` before `Finish Analysis` batch can be tracked since https://github.com/apache/spark/pull/18429#discussion_r124210428. And after https://github.com/apache/spark/pull/29673, we move `RewriteDistinctAggregates` out of the `Finish Analysis` batch. So I think it's good to move this rule now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
