cloud-fan commented on code in PR #36154:
URL: https://github.com/apache/spark/pull/36154#discussion_r849108481
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/numberFormatExpressions.scala:
##########
@@ -46,8 +46,10 @@ import org.apache.spark.unsafe.types.UTF8String
grouping separator relevant for the size of the number.
'$': Specifies the location of the $ currency sign. This character
may only be specified
once.
- 'S': Specifies the position of a '-' or '+' sign (optional, only
allowed once).
- 'MI': Specifies that 'expr' has an optional '-' sign, but no '+'
(only allowed once).
+ 'S': Specifies the position of a '-' or '+' sign (optional, only
allowed once at the
+ beginning or end of the format string).
+ 'MI': Specifies that 'expr' has an optional '-' sign, but no '+'
(only allowed once at the
Review Comment:
Shall we make the doc of `S` and `MI` more consistent? The only difference
is `S` allows `+` but `MI` does not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
