srowen commented on code in PR #36179:
URL: https://github.com/apache/spark/pull/36179#discussion_r849498103
##########
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala:
##########
@@ -1135,8 +1134,7 @@ final class ShuffleBlockFetcherIterator(
} else {
sendRequest(request)
}
- numBlocksInFlightPerAddress(remoteAddress) =
- numBlocksInFlightPerAddress.getOrElse(remoteAddress, 0) +
request.blocks.size
+ numBlocksInFlightPerAddress.getOrElse(remoteAddress, 0) +=
request.blocks.size
Review Comment:
It doesn't seem like this can work/compile? the result of getOrElse is an
int. Not sure if we can optimize this one.
The rest looks fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
