LuciferYang commented on code in PR #36195:
URL: https://github.com/apache/spark/pull/36195#discussion_r850212764
##########
core/src/main/scala/org/apache/spark/status/api/v1/ApplicationListResource.scala:
##########
@@ -37,15 +38,23 @@ private[v1] class ApplicationListResource extends
ApiRequestContext {
val includeCompleted = status.isEmpty ||
status.contains(ApplicationStatus.COMPLETED)
val includeRunning = status.isEmpty ||
status.contains(ApplicationStatus.RUNNING)
- uiRoot.getApplicationInfoList.filter { app =>
- val anyRunning = app.attempts.exists(!_.completed)
- // if any attempt is still running, we consider the app to also still be
running;
- // keep the app if *any* attempts fall in the right time window
- ((!anyRunning && includeCompleted) || (anyRunning && includeRunning)) &&
- app.attempts.exists { attempt =>
- isAttemptInRange(attempt, minDate, maxDate, minEndDate, maxEndDate,
anyRunning)
+ val applicationInfoList = uiRoot.getApplicationInfoList
Review Comment:
Cannot close `KVStoreIterator` in `getApplicationList` because it return an
`Iterator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
