ulysses-you commented on code in PR #36177:
URL: https://github.com/apache/spark/pull/36177#discussion_r851133121
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala:
##########
@@ -184,6 +202,21 @@ object EliminateOuterJoin extends Rule[LogicalPlan] with
PredicateHelper {
case a @ Aggregate(_, _, p @ Project(_, Join(_, right, RightOuter, _, _)))
if a.groupOnly && p.references.subsetOf(right.outputSet) =>
a.copy(child = p.copy(child = right))
+
+ case a @ Aggregate(_, aggExprs, Join(left, _, LeftOuter, _, _))
+ if a.references.subsetOf(left.outputSet) &&
allDuplicateAgnostic(aggExprs) =>
+ a.copy(child = left)
+ case a @ Aggregate(_, aggExprs, Join(_, right, RightOuter, _, _))
+ if a.references.subsetOf(right.outputSet) &&
allDuplicateAgnostic(aggExprs) =>
+ a.copy(child = right)
+ case a @ Aggregate(_, aggExprs, p @ Project(projectList, Join(left, _,
LeftOuter, _, _)))
Review Comment:
Seems it's hrad. `CollapseProject` supports collapse `Project(_, Aggregate)`
but does not support `Aggregate(_, _, Porject)` and that is we want to optimize.
The reason why we do not support is that we may lose column prune if we
collapse `Aggregate(_, _, Porject)` without check the child of Porject.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
