xinrong-databricks commented on code in PR #36186:
URL: https://github.com/apache/spark/pull/36186#discussion_r851411197
##########
python/pyspark/pandas/tests/test_series.py:
##########
@@ -998,6 +999,10 @@ def test_sort_values(self):
self.assert_eq(psser, pser.sort_values())
self.assert_eq(psdf, pdf)
+ psser.sort_values(inplace=True, ascending=False, ignore_index=True)
+ self.assert_eq(psser, pser.sort_values(ascending=False,
ignore_index=True))
+ self.assert_eq(psdf, pdf)
Review Comment:
Shall we be consistent with
https://github.com/apache/spark/blob/master/python/pyspark/pandas/tests/test_series.py#L1028-L1033
instead? Thanks!
##########
python/pyspark/pandas/tests/test_series.py:
##########
@@ -1032,6 +1039,10 @@ def test_sort_index(self):
self.assert_eq(psser, pser.sort_index())
self.assert_eq(psdf, pdf)
+ psser.sort_index(inplace=True, ascending=False, ignore_index=True)
+ self.assert_eq(psser, pser.sort_index(ascending=False,
ignore_index=True))
+ self.assert_eq(psdf, pdf)
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
