LuciferYang commented on PR #36237: URL: https://github.com/apache/spark/pull/36237#issuecomment-1101049714
> I'm not against this, but it adds complexity. Do you have any rough sense of how much it improves things? Sorry, I want to clarify the main goal of this pr: it is not for the benefit of performance, but to close `KVStoreIterator ` resources opened by `KVStore.view.iterator` in time. I hope `finalize()` method can be cleaned up later after this pr because using `finalize` to recycle resources is not a good way( for example, Effective Java Item 7 Avoid finalizers) and `finalize()` is identified as `deprecated` after Java 11 and `forRemoval=true` after Java 18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
