cloud-fan commented on code in PR #35041:
URL: https://github.com/apache/spark/pull/35041#discussion_r851926384
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/PercentileSuite.scala:
##########
@@ -38,36 +38,43 @@ class PercentileSuite extends SparkFunSuite {
}
Review Comment:
Seems we don't need to change this test suite at all. Now `PercentileDisc`
is almost the same with `Percentile`, just a few flags are different. Testing
`Percentile` should be good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
