anchovYu commented on code in PR #36241:
URL: https://github.com/apache/spark/pull/36241#discussion_r852236919
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala:
##########
@@ -626,7 +626,7 @@ object Decimal {
}
} catch {
case _: NumberFormatException =>
- throw QueryExecutionErrors.invalidInputSyntaxForNumericError(str,
errorContext)
+ throw
QueryExecutionErrors.invalidInputSyntaxForNumericError(DecimalType, str,
errorContext)
Review Comment:
I don't think we can get that concrete Decimal type because the cast fails:
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala#L629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
