beliefer commented on code in PR #35975:
URL: https://github.com/apache/spark/pull/35975#discussion_r852506526
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala:
##########
@@ -531,6 +532,52 @@ class AnalysisErrorSuite extends AnalysisTest {
"The limit expression must be equal to or greater than 0, but got -1" ::
Nil
)
+ errorTest(
+ "an evaluated offset class must not be string",
+ testRelation.offset(Literal(UTF8String.fromString("abc"), StringType)),
+ "The offset expression must be integer type, but got string" :: Nil
+ )
+
+ errorTest(
+ "an evaluated offset class must not be long",
+ testRelation.offset(Literal(10L, LongType)),
Review Comment:
This has nothing to do with it.
The cost of Limit or Offset is decided by its value. We shouldn't use long
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
