mridulm commented on code in PR #36238:
URL: https://github.com/apache/spark/pull/36238#discussion_r852599519
##########
core/src/main/scala/org/apache/spark/executor/Executor.scala:
##########
@@ -296,6 +332,8 @@ private[spark] class Executor(
} else {
taskRunner.kill(interruptThread = interruptThread, reason = reason)
}
+ // Safe to remove kill mark as we got a chance with the TaskRunner.
+ killMarks.remove(taskId)
Review Comment:
Start `try` at `killMarks.put` (beginning of method), and the remove goes in
the `finally`.
So that when method exits, it is always cleared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
