dtenedor commented on code in PR #35269:
URL: https://github.com/apache/spark/pull/35269#discussion_r853453632
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/NumberFormatter.scala:
##########
@@ -149,6 +156,21 @@ class NumberFormatter(originNumberFormat: String, isParse:
Boolean = true) exten
} else if (invalidSignPosition(DOLLAR_SIGN)) {
TypeCheckResult.TypeCheckFailure(
nonFistOrLastCharInNumberFormatError(s"'$DOLLAR_SIGN'"))
+ } else if (!isParse && normalizedNumberFormat.exists(_ == COMMA_SIGN)) {
Review Comment:
@beliefer Sure I can be happy to help. I can prepare the change and then
send it to yourself and Wenchen for review. Sorry for the churn in the code
making things complicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
